Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better versioning #1004

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Better versioning #1004

merged 1 commit into from
Feb 22, 2025

Conversation

WSSDude
Copy link
Collaborator

@WSSDude WSSDude commented Feb 22, 2025 •
edited
Loading

Untitled

@WSSDude WSSDude requested a review from maximegmd February 22, 2025 09:24
@WSSDude
Better versioning
6f2b83b 
* Version info based off git information
* Add autogenerated resource file so the final DLL has some version info
* Cleaner inclusion of autogenerated files (prevents constant stdafx.h rebuilds and puts resulting files into some more normal directory)
* Fix #894
@WSSDude WSSDude force-pushed the feature/dll-resource branch from 224cf12 to 6f2b83b Compare February 22, 2025 09:29
maximegmd
maximegmd approved these changes Feb 22, 2025
View reviewed changes
Copy link
Owner

@maximegmd maximegmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maximegmd maximegmd merged commit c3fd1db into master Feb 22, 2025
2 checks passed
@WSSDude WSSDude deleted the feature/dll-resource branch February 22, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximegmd maximegmd maximegmd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: include CET version number within the asi (or somewhere else)
2 participants
@WSSDude @maximegmd